Messages in this thread | | | Date | Wed, 2 Sep 2015 11:17:59 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 12/15] tools lib api: Add configured support for fs |
| |
Em Wed, Sep 02, 2015 at 03:46:25PM +0200, Jiri Olsa escreveu: > On Wed, Sep 02, 2015 at 10:39:31AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Sep 02, 2015 at 09:56:42AM +0200, Jiri Olsa escreveu: > > > Adding name__mount (where name is in sysfs,procfs,debugfs,tracefs)
The cut'n'paste error I mentioned was in the above line, BTW.
> > > interface that returns bool state of the filesystem mount: > > > true - mounted, false - not mounted > > > > Well, why not take the opportunity and call it... name__mounted()? > > "__configured()" is too vague... > > I mirrored the debugfs/tracefs object interface > we can have another patch changing that
Ok, agreed, will leave it as configured() and then we can change it.
> > > > Also there was some cut'n'pasting mistake here... if you agree I can fix > > it all up and make this change, well, I'm doing it on my local tree, > > holler if you have any objection :) > > > > > It will not try to mount the filesystem. > > > > No FSTYPE__configured() (to-be FSTYPE__mounted()) doesn't mount > > anything, that is what FSTYPE__mount() does :-) > > I stated it just to be clear ;-)
Sure, somehow the cut'n'paste error on the first line flipped a bit in my brain, sorry ;-\
- arnaldo
| |