lkml.org 
[lkml]   [2015]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/15] tools lib api: Add configured support for fs
Em Wed, Sep 02, 2015 at 03:46:25PM +0200, Jiri Olsa escreveu:
> On Wed, Sep 02, 2015 at 10:39:31AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Sep 02, 2015 at 09:56:42AM +0200, Jiri Olsa escreveu:
> > > Adding name__mount (where name is in sysfs,procfs,debugfs,tracefs)

The cut'n'paste error I mentioned was in the above line, BTW.

> > > interface that returns bool state of the filesystem mount:
> > > true - mounted, false - not mounted
> >
> > Well, why not take the opportunity and call it... name__mounted()?
> > "__configured()" is too vague...
>
> I mirrored the debugfs/tracefs object interface
> we can have another patch changing that

Ok, agreed, will leave it as configured() and then we can change it.

> >
> > Also there was some cut'n'pasting mistake here... if you agree I can fix
> > it all up and make this change, well, I'm doing it on my local tree,
> > holler if you have any objection :)
> >
> > > It will not try to mount the filesystem.
> >
> > No FSTYPE__configured() (to-be FSTYPE__mounted()) doesn't mount
> > anything, that is what FSTYPE__mount() does :-)
>
> I stated it just to be clear ;-)

Sure, somehow the cut'n'paste error on the first line flipped a bit in
my brain, sorry ;-\

- arnaldo


\
 
 \ /
  Last update: 2015-09-02 16:41    [W:0.142 / U:1.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site