lkml.org 
[lkml]   [2015]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 3/3] perf,test: test cpu topology
On Tue, Sep 01, 2015 at 11:25:10PM +0000, Liang, Kan wrote:
>
>
> >
> > Em Tue, Sep 01, 2015 at 09:58:13AM -0400, Kan Liang escreveu:
> > > From: Jiri Olsa <jolsa@kernel.org>
> > >
> > > This patch test cpu core_id and socket_id which are stored in perf_env.
> > >
> > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > Signed-off-by: Kan Liang <kan.liang@intel.com>
> > > ---
> > >
> > > Changes since jirka's original version
> > > - Use pr_debug to replace fprintf
> > > - Add date_size to avoid warning
> > > - Introduce cpu_map, and compare core_id and socket_id
> > > between cpu_map and perf_env
> >
> > Humm, two questions:
> >
> > Since you changed it that much, wouldn't be better to give you the
> > authorship while still giving credit to Jiri for the original version?
> > Something like:
> >
> > Based-on-a-patch-by: Jiri Olsa
>
> Jiri, are you OK with that?

yep

>
> >
> > [acme@zoo linux]$ git log | grep Based-on-patch-by: | wc -l
> > 61
> > [acme@zoo linux]$ git log | grep Based-on-a-patch-by: | wc -l
> > 4
> > [acme@zoo linux]$
> >
> > But then you need to resubmit this anyway, as you forgot to do the:
> >
> > git add tools/perf/tests/topology.c
>
> Ah... My bad. :(
>
> I will resubmit the patch then.

I'll review new version

jirka


\
 
 \ /
  Last update: 2015-09-02 08:21    [W:0.051 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site