lkml.org 
[lkml]   [2015]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2 055/120] spi: img-spfi: check for timeout error before proceeding
    Date
    4.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sifan Naeem <sifan.naeem@imgtec.com>

    commit 011710e2ab659c7ad6e5e554806414bd7a9508be upstream.

    Calling spfi_wait_all_done is not required if the transfer has timed
    out before all data is transferred.

    spfi_wait_all_done polls for Alldone interrupt which is triggered to
    mark the transfer as complete and to indicate it is now safe to issue
    a new transfer.

    Fixes: 8c2c8c0 ("spi: img-spfi: Control CS lines with GPIO")
    Signed-off-by: Sifan Naeem <sifan.naeem@imgtec.com>
    Reviewed-by: Andrew Bresticker <abrestic@chromium.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/spi-img-spfi.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/spi/spi-img-spfi.c
    +++ b/drivers/spi/spi-img-spfi.c
    @@ -267,15 +267,15 @@ static int img_spfi_start_pio(struct spi
    cpu_relax();
    }

    - ret = spfi_wait_all_done(spfi);
    - if (ret < 0)
    - return ret;
    -
    if (rx_bytes > 0 || tx_bytes > 0) {
    dev_err(spfi->dev, "PIO transfer timed out\n");
    return -ETIMEDOUT;
    }

    + ret = spfi_wait_all_done(spfi);
    + if (ret < 0)
    + return ret;
    +
    return 0;
    }




    \
     
     \ /
      Last update: 2015-09-19 20:21    [W:4.031 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site