Messages in this thread | | | Date | Fri, 18 Sep 2015 09:36:15 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/2] x86/math-emu: Remove define layer for undocumented opcodes |
| |
* Denys Vlasenko <dvlasenk@redhat.com> wrote:
> No code changes. > > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> > CC: Ingo Molnar <mingo@kernel.org> > CC: Borislav Petkov <bp@alien8.de> > CC: "H. Peter Anvin" <hpa@zytor.com> > CC: Andy Lutomirski <luto@amacapital.net> > CC: Kees Cook <keescook@chromium.org> > CC: x86@kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/x86/math-emu/fpu_entry.c | 29 +++++++++-------------------- > 1 file changed, 9 insertions(+), 20 deletions(-)
This patch should come before riskier patches introducing new instructions, to make eventual reverts and fixes easier.
The rule is generally: sort patches by risk, low risk first, high risk later. This means that cleanups, restructuring, refactoring patches always come first - beyond making bisection and reverts easier, those make subsequent patches cleaner as well and make any bugs in subsequent patches easier to see as well.
Thanks,
Ingo
| |