Messages in this thread | | | From | Jean-Michel Hautbois <> | Date | Fri, 18 Sep 2015 14:38:27 +0200 | Subject | spi-imx: wait_for_completion should timeout even in non-DMA transfer cases |
| |
Hi,
I am wondering why in spi-imx the spi_imx_pio_transfer() function is calling wait_for_completion() and not wait_for_completion_timeout() as in the spi_imx_dma_transfer() one. I can't see a good reason for this, maybe should it be calculated based on the spi clock and transfer->len, or at least be the same as IMX_DMA_TIMEOUT which is 3 seconds ? If you want it, I have a patch, just tell me if you are interested and if you prefer a calculated timeout or even something else ?
Thanks, JM
| |