Messages in this thread | | | Date | Thu, 17 Sep 2015 13:53:16 -0700 (PDT) | From | Palmer Dabbelt <> | Subject | Re: [PATCH 03/13] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c |
| |
On Thu, 17 Sep 2015 02:57:12 PDT (-0700), dhowells@redhat.com wrote: > Palmer Dabbelt <palmer@dabbelt.com> wrote: > >> +#ifdef CONFIG_COMPAT >> +/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */ >> +#define COMPAT_ATM_ADDPARTY _IOW('a', ATMIOC_SPECIAL+4, struct compat_atm_iobuf) >> +#endif > > I wonder if it would hurt to ditch the conditionals entirely. It only eats > cpp namespace, not C namespace so it won't affect the output if it is not used > because the code that uses it is compiled out.
Makes sense to me.
| |