lkml.org 
[lkml]   [2015]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: lustre: lustre: mdc: lproc_mdc.c: declared file_operations struct as const
On Wed, Sep 16, 2015 at 06:01:01PM +0530, Sakshi Vaid wrote:
> Declared the file_operations structure as const as done elsewhere in the
> kernel, as there are no modifiactions to this field.
>
> Following warning found by checkpatch
> WARNING: struct file_operations should normally be const
>
> Signed-off-by: Sakshi Vaid <sakshivaid95@gmail.com>
> ---
> drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c b/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
> index c791941..c62c0ac 100644
> --- a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
> +++ b/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
> @@ -146,7 +146,7 @@ static ssize_t mdc_kuc_write(struct file *file,
> return count;
> }
>
> -struct file_operations mdc_kuc_fops = {
> +const struct file_operations mdc_kuc_fops = {
> .open = mdc_kuc_open,
> .write = mdc_kuc_write,
> .release = single_release,

This doesn't apply to my tree at all, what are you making it against?


\
 
 \ /
  Last update: 2015-09-17 06:41    [W:1.149 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site