lkml.org 
[lkml]   [2015]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] arch-powerpc: Return false instead of -EFAULT
From
Date
On Thu, 2015-09-17 at 11:18 +0200, Peter Senna Tschudin wrote:
> Returning a negative value for a boolean function seem to have the
> undesired effect of returning true. Replace -EINVAL by false in a
> bool-returning function.
>
> The diff of the .s file before and after the change (using cross
> compilation) starts with:
>
> 440,441c440,441
> < .L43:
> < li 3,1 # D.25775,
> ---
> > .L42:
> > li 3,0 # D.25775,
> ...
>
> while if -EFAULT is replaced by true, the diff is empty.

Ah, that's rather unfortunate.

Can you post the full asm listing, for all three cases?

cheers




\
 
 \ /
  Last update: 2015-09-17 12:01    [W:0.034 / U:73.904 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site