Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [Y2038] [PATCH V2] hp_sdc_rtc: fixed y2038 problem in proc_show | Date | Wed, 16 Sep 2015 15:55:37 +0200 |
| |
On Wednesday 16 September 2015 21:45:38 WEN Pingbo wrote: > hp_sdc_rtc_proc_show() use timeval to store the time, which will > overflowed in 2038. > > This patch fixes this problem by replacing timeval with timespec64. > hp_sdc_rtc_proc_show() only output string, so that userspace will work > normally if we apply this patch. > > Not all timer in i8042 have y2038 risk(handshake, match timer, etc), > Replacements in those timer are just for consistency. > > Version 2 Updates: > - compiled in m68k gcc cross compiler(4.6.3), no extra warnings > - placed s64 type cast in tv.tv_sec, making sure it work properly in > both 32bit and 64bit platform. > > Signed-off-by: WEN Pingbo <pingbo.wen@linaro.org> > Cc: Y2038 <y2038@lists.linaro.org> >
Looks very good,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
| |