lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/5] spi: introduce mmap read support for spi flash devices
Date


On 09/15/2015 12:05 AM, Mark Brown wrote:
> On Fri, Sep 04, 2015 at 04:55:33PM +0530, Jagan Teki wrote:
>> On 4 September 2015 at 13:59, Vignesh R <vigneshr@ti.com> wrote:
>
>>> + * @spi_mtd_mmap_read: some spi-controller hardwares provide memory
>>> + * mapped interface to communicate with mtd flashes.
>>> + * For this, spi controller needs to know flash
>>> + * memory settings like read command to use, dummy
>>> + * bytes and address width. Once these settings are
>>> + * populated in hardware registers, any read
>>> + * accesses to flash's memory map region(as defined
>>> + * by SoC) through memcpy or mem-to-mem DMA copy
>>> + * will be handled by controller hardware. The
>>> + * hardware will automatically generate spi signals
>>> + * required to read data from flash and present it
>>> + * to CPU or DMA. SPI master drivers can use this
>>> + * callback to implement memory mapped read
>>> + * interface. Flash driver (like m25p80) requests
>>> + * memory mapped read via this method. The interface
>>> + * should only be used mtd flashes and cannot be
>>> + * used with other spi devices.
>
> This comment is *way* too verbose - probably you just need up to the
> "Once" here.
>

Ok, I will move the extra text to commit log.


--
Thanks,
Vignesh


\
 
 \ /
  Last update: 2015-09-16 12:21    [W:0.096 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site