lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 02/31] arch/ia64/tioce: use kmemdup rather than duplicating its implementation
From
Date
Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> arch/ia64/sn/pci/tioce_provider.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> index 46d3df4..2f13276 100644
> --- a/arch/ia64/sn/pci/tioce_provider.c
> +++ b/arch/ia64/sn/pci/tioce_provider.c
> @@ -1000,11 +1000,11 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
> * Allocate kernel bus soft and copy from prom.
> */
>
> - tioce_common = kzalloc(sizeof(struct tioce_common), GFP_KERNEL);
> + tioce_common = kmemdup(prom_bussoft, sizeof(struct tioce_common),
> + GFP_KERNEL);
> if (!tioce_common)
> return NULL;
>
> - memcpy(tioce_common, prom_bussoft, sizeof(struct tioce_common));
> tioce_common->ce_pcibus.bs_base = (unsigned long)
> ioremap(REGION_OFFSET(tioce_common->ce_pcibus.bs_base),
> sizeof(struct tioce_common));



\
 
 \ /
  Last update: 2015-09-16 12:01    [W:0.463 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site