lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management
From
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Sat, 12 Sep 2015 13:45:22 +0200

> Instead of using directly the OS timer through direct register access,
> use the standard sched_clock(), which will end up in OSCR reading
> anyway.
>
> This is a first step for direct access register removal and machine
> specific code removal from this driver.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>

What is the granularity of the OSCR register?

If it is not nanoseconds, then you need to adjust calculations
such as this one:

> @@ -549,7 +548,7 @@ static int pxa_irda_hard_xmit(struct sk_buff *skb, struct net_device *dev)
> skb_copy_from_linear_data(skb, si->dma_tx_buff, skb->len);
>
> if (mtt)
> - while ((unsigned)(readl_relaxed(OSCR) - si->last_oscr)/4 < mtt)
> + while ((sched_clock() - si->last_clk) / 4 < mtt)
> cpu_relax();


\
 
 \ /
  Last update: 2015-09-16 02:01    [W:0.097 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site