Messages in this thread | | | Subject | Re: [PATCH v2 2/8] KVM: x86: add pcommit support | From | Paolo Bonzini <> | Date | Tue, 15 Sep 2015 17:30:35 +0200 |
| |
On 09/09/2015 08:05, Xiao Guangrong wrote: > + if (!guest_cpuid_has_pcommit(vcpu) && nested) > + vmx->nested.nested_vmx_secondary_ctls_high &= > + ~SECONDARY_EXEC_PCOMMIT;
It is legal to set CPUID multiple times, so I think we need
if (static_cpu_has(X86_FEATURE_PCOMMIT) && nested) { if (guest_cpuid_has_pcommit(vcpu)) vmx->nested.nested_vmx_secondary_ctls_high |= SECONDARY_EXEC_PCOMMIT; else vmx->nested.nested_vmx_secondary_ctls_high &= ~SECONDARY_EXEC_PCOMMIT; }
The INVPCID exit probably should be handled the same way as PCOMMIT; moving both to a new nested_vmx_update_ctls_msrs probably makes sense.
This can be done on top of this series.
Paolo
| |