lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 28/39] ecryptfs: drop null test before destroy functions
On 2015-09-15 06:36:30, Julia Lawall wrote:
>
>
> On Mon, 14 Sep 2015, Tyler Hicks wrote:
>
> > On 2015-09-13 14:15:21, Julia Lawall wrote:
> > > Remove unneeded NULL test.
> > >
> > > The semantic patch that makes this change is as follows:
> > > (http://coccinelle.lip6.fr/)
> > >
> > > // <smpl>
> > > @@ expression x; @@
> > > -if (x != NULL)
> > > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> > > // </smpl>
> > >
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > Acked-by: Tyler Hicks <tyhicks@canonical.com>
> >
> > I assume that you'll be landing this patch set into Linus' tree all
> > together. Let me know if that's incorrect and I should take this single
> > patch into the eCryptfs dev tree.
>
> I'm not doing anythign after this point. Some others have taken the patch
> into their trees.

I've taken it into my tree. Thanks again.

Tyler

>
> julia
>
> >
> > Thanks!
> >
> > Tyler
> >
> > >
> > > ---
> > > fs/ecryptfs/main.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> > > index 4f4d047..e83f31c 100644
> > > --- a/fs/ecryptfs/main.c
> > > +++ b/fs/ecryptfs/main.c
> > > @@ -737,8 +737,7 @@ static void ecryptfs_free_kmem_caches(void)
> > > struct ecryptfs_cache_info *info;
> > >
> > > info = &ecryptfs_cache_infos[i];
> > > - if (*(info->cache))
> > > - kmem_cache_destroy(*(info->cache));
> > > + kmem_cache_destroy(*(info->cache));
> > > }
> > > }
> > >
> > >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-09-15 17:01    [W:0.073 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site