lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/26] usb: gadget: fix few outdated comments
    Date
    Fix comments in code to make them up to date.

    composite: claiming endpoint is now done by setting ep->claimed flag,
    not ep->driver_data.

    epautoconf: usb_ep_autoconfig() and usb_ep_autoconfig_ss() return
    claimed endpoint with ep->claimed flag already set.

    Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
    ---
    drivers/usb/gadget/composite.c | 4 +---
    drivers/usb/gadget/epautoconf.c | 8 ++++----
    2 files changed, 5 insertions(+), 7 deletions(-)

    diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
    index b474499..3e95c0e 100644
    --- a/drivers/usb/gadget/composite.c
    +++ b/drivers/usb/gadget/composite.c
    @@ -839,9 +839,7 @@ int usb_add_config(struct usb_composite_dev *cdev,
    }
    }

    - /* set_alt(), or next bind(), sets up
    - * ep->driver_data as needed.
    - */
    + /* set_alt(), or next bind(), sets up ep->claimed as needed */
    usb_ep_autoconfig_reset(cdev->gadget);

    done:
    diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadget/epautoconf.c
    index 6399c10..0f4ece4 100644
    --- a/drivers/usb/gadget/epautoconf.c
    +++ b/drivers/usb/gadget/epautoconf.c
    @@ -53,13 +53,13 @@
    * the restrictions that may apply. Some combinations of driver
    * and hardware won't be able to autoconfigure.
    *
    - * On success, this returns an un-claimed usb_ep, and modifies the endpoint
    + * On success, this returns an claimed usb_ep, and modifies the endpoint
    * descriptor bEndpointAddress. For bulk endpoints, the wMaxPacket value
    * is initialized as if the endpoint were used at full speed and
    * the bmAttribute field in the ep companion descriptor is
    * updated with the assigned number of streams if it is
    * different from the original value. To prevent the endpoint
    - * from being returned by a later autoconfig call, claim it by
    + * from being returned by a later autoconfig call, claims it by
    * assigning ep->claimed to true.
    *
    * On failure, this returns a null endpoint descriptor.
    @@ -154,10 +154,10 @@ EXPORT_SYMBOL_GPL(usb_ep_autoconfig_ss);
    * USB controller, and it can't know all the restrictions that may apply.
    * Some combinations of driver and hardware won't be able to autoconfigure.
    *
    - * On success, this returns an un-claimed usb_ep, and modifies the endpoint
    + * On success, this returns an claimed usb_ep, and modifies the endpoint
    * descriptor bEndpointAddress. For bulk endpoints, the wMaxPacket value
    * is initialized as if the endpoint were used at full speed. To prevent
    - * the endpoint from being returned by a later autoconfig call, claim it
    + * the endpoint from being returned by a later autoconfig call, claims it
    * by assigning ep->claimed to true.
    *
    * On failure, this returns a null endpoint descriptor.
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-09-15 17:01    [W:4.446 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site