lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/26] usb: gadget: f_mass_storage: eliminate abuse of ep->driver data
    Date
    Since ep->driver_data is not used for endpoint claiming, neither for
    enabled/disabled state storing, we can reduce number of places where
    we read or modify it's value, as now it has no particular meaning for
    function or framework logic.

    In case of f_mass_storage we only need to store in ep->driver_data
    pointer to struct fsg_common, which is used in bulk_in_complete() and
    bulk_out_complete() callbacks. All other uses of ep->driver_data are now
    meaningless and can be safely removed.

    Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
    ---
    drivers/usb/gadget/function/f_mass_storage.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
    index a6eb537..5ae7473 100644
    --- a/drivers/usb/gadget/function/f_mass_storage.c
    +++ b/drivers/usb/gadget/function/f_mass_storage.c
    @@ -2258,12 +2258,10 @@ reset:
    /* Disable the endpoints */
    if (fsg->bulk_in_enabled) {
    usb_ep_disable(fsg->bulk_in);
    - fsg->bulk_in->driver_data = NULL;
    fsg->bulk_in_enabled = 0;
    }
    if (fsg->bulk_out_enabled) {
    usb_ep_disable(fsg->bulk_out);
    - fsg->bulk_out->driver_data = NULL;
    fsg->bulk_out_enabled = 0;
    }

    @@ -3070,13 +3068,11 @@ static int fsg_bind(struct usb_configuration *c, struct usb_function *f)
    ep = usb_ep_autoconfig(gadget, &fsg_fs_bulk_in_desc);
    if (!ep)
    goto autoconf_fail;
    - ep->driver_data = fsg->common; /* claim the endpoint */
    fsg->bulk_in = ep;

    ep = usb_ep_autoconfig(gadget, &fsg_fs_bulk_out_desc);
    if (!ep)
    goto autoconf_fail;
    - ep->driver_data = fsg->common; /* claim the endpoint */
    fsg->bulk_out = ep;

    /* Assume endpoint addresses are the same for both speeds */
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-09-15 16:41    [W:4.228 / U:1.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site