lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 26/33] lpfc: Fix scsi prep dma buf error.
    Date
    From: James Smart <james.smart@avagotech.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 5116fbf136ea21b8678a85eee5c03508736ada9f upstream.

    Didn't check for less-than-or-equal zero. Means we may later call
    scsi_dma_unmap() even though we don't have valid mappings.

    Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
    Signed-off-by: James Smart <james.smart@avagotech.com>
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: James Bottomley <JBottomley@Odin.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/scsi/lpfc/lpfc_scsi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
    index c913e8cc3b26..ed7759980c47 100644
    --- a/drivers/scsi/lpfc/lpfc_scsi.c
    +++ b/drivers/scsi/lpfc/lpfc_scsi.c
    @@ -3423,7 +3423,7 @@ lpfc_scsi_prep_dma_buf_s4(struct lpfc_hba *phba, struct lpfc_scsi_buf *lpfc_cmd)
    */

    nseg = scsi_dma_map(scsi_cmnd);
    - if (unlikely(!nseg))
    + if (unlikely(nseg <= 0))
    return 1;
    sgl += 1;
    /* clear the last flag in the fcp_rsp map entry */
    --
    2.5.2


    \
     
     \ /
      Last update: 2015-09-15 16:41    [W:3.017 / U:1.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site