lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 017/146] UBI: initialize LEB number variable
    Date
    From: Brian Norris <computersforpeace@gmail.com>

    3.4.109-rc1 review patch. If anyone has any objections, please let me know.

    ------------------


    commit f16db8071ce18819fbd705ddcc91c6f392fb61f8 upstream.

    In some of the 'out_not_moved' error paths, lnum may be used
    uninitialized. Don't ignore the warning; let's fix it.

    This uninitialized variable doesn't have much visible effect in the end,
    since we just schedule the PEB for erasure, and its LEB number doesn't
    really matter (it just gets printed in debug messages). But let's get it
    straight anyway.

    Coverity CID #113449

    Signed-off-by: Brian Norris <computersforpeace@gmail.com>
    Signed-off-by: Richard Weinberger <richard@nod.at>
    [lizf: Backported to 3.4: adjust context]
    Signed-off-by: Zefan Li <lizefan@huawei.com>
    ---
    drivers/mtd/ubi/wl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
    index 7c1a9bf..284d144 100644
    --- a/drivers/mtd/ubi/wl.c
    +++ b/drivers/mtd/ubi/wl.c
    @@ -666,7 +666,7 @@ static int wear_leveling_worker(struct ubi_device *ubi, struct ubi_work *wrk,
    int cancel)
    {
    int err, scrubbing = 0, torture = 0, protect = 0, erroneous = 0;
    - int vol_id = -1, uninitialized_var(lnum);
    + int vol_id = -1, lnum = -1;
    struct ubi_wl_entry *e1, *e2;
    struct ubi_vid_hdr *vid_hdr;

    --
    1.9.1


    \
     
     \ /
      Last update: 2015-09-15 11:21    [W:4.447 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site