lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'
    Date
    On Wednesday, September 16, 2015 03:57:05 AM Rafael J. Wysocki wrote:
    > On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote:
    > > global_lock is defined as an unsigned long and accessing only its lower
    > > 32 bits from sysfs is incorrect, as we need to consider other 32 bits
    > > for big endian 64 bit systems.
    > >
    > > Fix that by making global_lock an u32 instead.
    > >
    > > Cc: <stable@vger.kernel.org> # v4.1+
    > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    > >
    > > ---
    > > Its marked just for # v4.1+, because arm64 has the first 64 big-endian
    > > platform with ACPI. And ACPI support for that is mainlined recently
    > > only (Arnd Bergmann).
    >
    > OK
    >
    > So are you aware of any ARM platform implementing the ACPI EC?
    >
    > I am not. Moreover, I'm not aware of any plans in that area.

    In any case, please just split the EC-related changes off from your second
    patch and send them separately.

    Thanks,
    Rafael



    \
     
     \ /
      Last update: 2015-09-16 03:41    [W:7.911 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site