lkml.org 
[lkml]   [2015]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/39] aoe: drop null test before destroy functions
ACK.  Thanks.

On 09/13/2015 08:15 AM, Julia Lawall wrote:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
> \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/block/aoe/aoedev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
> index ffd1947..efc8a8a 100644
> --- a/drivers/block/aoe/aoedev.c
> +++ b/drivers/block/aoe/aoedev.c
> @@ -285,8 +285,7 @@ freedev(struct aoedev *d)
> e = t + d->ntargets;
> for (; t < e && *t; t++)
> freetgt(d, *t);
> - if (d->bufpool)
> - mempool_destroy(d->bufpool);
> + mempool_destroy(d->bufpool);
> skbpoolfree(d);
> minor_free(d->sysminor);
>
>



\
 
 \ /
  Last update: 2015-09-15 04:01    [W:0.245 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site