Messages in this thread | | | Date | Mon, 14 Sep 2015 21:20:33 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file VMAs have ->vm_ops set") |
| |
On Mon, Sep 14, 2015 at 07:05:47PM +0200, Oleg Nesterov wrote: > On 09/14, Kirill A. Shutemov wrote: > > > > Fix is below. I don't really like it, but I cannot find any better > > solution. > > Me too... > > But this change "documents" the nasty special "vm_file && !vm_ops" case, and > I am not sure how we can remove it later... > > So perhaps we should change vma_is_anonymous() back to check ->fault too, > > static inline bool vma_is_anonymous(struct vm_area_struct *vma) > { > - return !vma->vm_ops; > + return !vma->vm_ops || !vma->vm_ops->fault;
No. This would give a lot false positives from drives which setup page tables upfront and don't use ->fault at all.
> } > > and remove the "vma->vm_file && !vma->vm_ops" checks in mmap_region() paths. > > I dunno. > > Oleg. > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
-- Kirill A. Shutemov
| |