Messages in this thread | | | Date | Sat, 12 Sep 2015 08:10:46 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH 4/4] Staging: vt6656: Bool tests don't need comparisons |
| |
On Sat, 12 Sep 2015, Shraddha Barke wrote:
> This patch removes comparisons to true/false values on bool variables. > Fix made using Coccinelle > > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com> > --- > drivers/staging/vt6656/wcmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c > index 3cbf479..ab7401e 100644 > --- a/drivers/staging/vt6656/wcmd.c > +++ b/drivers/staging/vt6656/wcmd.c > @@ -177,7 +177,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command) > ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE); > priv->free_cmd_queue--; > > - if (priv->cmd_running == false) > + if (priv->cmd_running)
You turned it into a test for true. It seems strange that this would happen if you used a rule.
julia
> vnt_cmd_complete(priv); > > return true; > -- > 2.1.4 > >
| |