[lkml]   [2015]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 2.6.32 04/62] TTY: drop driver reference in tty_open fail path
2.6.32-longterm review patch.  If anyone has any objections, please let me know.


From: Jiri Slaby <>

commit c290f8358acaeffd8e0c551ddcc24d1206143376 upstream.

When tty_driver_lookup_tty fails in tty_open, we forget to drop a
reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
tty lookup/reopen to caller).

Fix that by adding tty_driver_kref_put to the fail path.

I will refactor the code later. This is for the ease of backporting to

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <>
Cc: Alan Cox <>
Acked-by: Sukadev Bhattiprolu <>
Signed-off-by: Greg Kroah-Hartman <>
[bwh: Backported to 2.6.32: adjust filename]
Signed-off-by: Ben Hutchings <>


Signed-off-by: Willy Tarreau <>
drivers/char/tty_io.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index cbdd1698..6c71534 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -1779,6 +1779,7 @@ got_driver:

if (IS_ERR(tty)) {
+ tty_driver_kref_put(driver);
return PTR_ERR(tty);

 \ /
  Last update: 2015-09-13 01:41    [W:0.214 / U:6.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site