lkml.org 
[lkml]   [2015]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro
On Sat, Sep 12, 2015 at 04:47:23PM +0530, Shraddha Barke wrote:
>
>
> On Sat, Sep 12, 2015 at 3:17 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>
> On 10/09/15 17:32, Shraddha Barke wrote:
> > This patch replaces bit shifting on 1 with the BIT(x) macro
> >
> > This was done with coccinelle:
> > @@ int g; @@
> >
> > -(1 << g)
> > +BIT(g)
> >
> > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> Something odd happened here as this is only a small proportion of the cases
> that should be updated in this file.  There's one at the bottom of the
> patch for starters!
>
>
> I didn't apply BIT(x) for mixed cases.I think I should drop this patch
> altogether but
> Greg has added it. Will it cause problems ? :(

Greg can always drop it :)


\
 
 \ /
  Last update: 2015-09-12 18:01    [W:0.048 / U:11.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site