lkml.org 
[lkml]   [2015]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2 3/4] Staging: rtl8712: Bool tests don't need comparisons
On Sat, Sep 12, 2015 at 04:35:30PM +0530, Shraddha Barke wrote:
> This patch removes comparisons to true/false values on bool variables.
> Fix made using Coccinelle
>
> Changes in v2-
> More instances covered
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
You have not even build tested before sending.
> drivers/staging/rtl8712/rtl871x_ioctl_set.c | 24 ++++-----
> drivers/staging/rtl8712/rtl871x_mlme.c | 77 ++++++++++++++---------------
> 2 files changed, 50 insertions(+), 51 deletions(-)
<snip>
>
> @@ -1131,9 +1130,9 @@ int r8712_select_and_join_from_scan(struct mlme_priv *pmlmepriv)
> phead = &queue->queue;
> pmlmepriv->pscanned = phead->next;
> while (1) {
> - if (end_of_queue_search(phead, pmlmepriv->pscanned) == true) {
> - if ((pmlmepriv->assoc_by_rssi == true) &&
> - (pnetwork_max_rssi != NULL)) {
> + if (end_of_queue_search(phead, pmlmepriv->pscanned)) {
> + if ((pmlmepriv->assoc_by_rssi) &&
> + (pnetwork_max_rssi))
Coccinelle will not remove the opening brace.

And in one part of the patch one test for !=NULL was modified.

regards
sudip


\
 
 \ /
  Last update: 2015-09-12 14:01    [W:0.032 / U:15.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site