lkml.org 
[lkml]   [2015]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] irda: ali-ircc: Fix deadlock in ali_ircc_sir_change_speed()
From
From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Sat, 12 Sep 2015 00:34:48 +0300

> ali_ircc_sir_change_speed() is always called with self->lock held,
> so acquiring the lock inside it leads to unavoidable deadlock.
>
> Call graph:
> ali_ircc_sir_change_speed() is called from ali_ircc_change_speed()
> ali_ircc_fir_hard_xmit() under spin_lock_irqsave(&self->lock, flags);
> ali_ircc_sir_hard_xmit() under spin_lock_irqsave(&self->lock, flags);
> ali_ircc_net_ioctl() under spin_lock_irqsave(&self->lock, flags);
> ali_ircc_dma_xmit_complete()
> ali_ircc_fir_interrupt()
> ali_ircc_interrupt() under spin_lock(&self->lock);
> ali_ircc_sir_write_wakeup()
> ali_ircc_sir_interrupt()
> ali_ircc_interrupt() under spin_lock(&self->lock);
>
> The patch removes spin_lock/unlock from ali_ircc_sir_change_speed().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Looks good, applied, thanks.


\
 
 \ /
  Last update: 2015-09-12 02:01    [W:0.294 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site