Messages in this thread |  | | Date | Thu, 10 Sep 2015 22:48:30 +0300 | From | Mikko Rapeli <> | Subject | Re: [PATCH 96/98] HACK include/uapi/linux/coda_psdev.h: fix compilation in userspace |
| |
On Sun, May 31, 2015 at 07:19:13AM -0400, Jan Harkes wrote: > On Sat, May 30, 2015 at 05:39:28PM +0200, Mikko Rapeli wrote: > > Include linux/coda.h for caddr_t and use unsigned short type directly. > > Userspace headers do not have list_head and wait_queue_head_t so just > > ifdef them away which is a HACK. Any ideas how to fix this properly? > > I grepped the Coda userspace sources and it doesn't look like this > particular struct is used there anyway, it is only used by the kernel > module to track which requests are waiting to be read by the Coda > userspace application and after that which requests are waiting for a > response. > > I guess a proper fix would be to move this struct to a non-uapi header, > or maybe even to the (probably) only C file in the kernel where it is > used.
Thanks! I'm moving upc_req definition to kernel side linux/coda_psdev.h in the next version of the patches.
-Mikko
|  |