lkml.org 
[lkml]   [2015]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/early_ioremap: add explicit #include of asm/early_ioremap.h
From
Date
On Thu, 2015-09-10 at 18:00 +0200, Ard Biesheuvel wrote:
> Commit 6b0f68e32ea8 ("mm: add utility for early copy from unmapped
> ram") introduces a function copy_from_early_mem() into mm/early_ioremap.c
> which itself calls early_memremap()/early_memunmap(). However, since
> early_memunmap() has not been declared yet at this point in the .c file,
> nor by any explicitly included header files, we are depending on a
> transitive include of asm/early_ioremap.h to declare it, which is fragile.
>
> So instead, include this header explicitly.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---

Acked-by: Mark Salter <msalter@redhat.com>

>
> I ran into this by accident when trying to enable to the generic ioremap
> implementation for 32-bit ARM.
>
> mm/early_ioremap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/early_ioremap.c b/mm/early_ioremap.c
> index 23f744d77ce0..17ae14b5aefa 100644
> --- a/mm/early_ioremap.c
> +++ b/mm/early_ioremap.c
> @@ -15,6 +15,7 @@
> #include <linux/mm.h>
> #include <linux/vmalloc.h>
> #include <asm/fixmap.h>
> +#include <asm/early_ioremap.h>
>
> #ifdef CONFIG_MMU
> static int early_ioremap_debug __initdata;



\
 
 \ /
  Last update: 2015-09-10 19:01    [W:0.050 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site