lkml.org 
[lkml]   [2015]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH 1/3] perf probe: Free perf probe event in cleanup_perf_probe_events()
Date
Hi Namhyung,

>From: Namhyung Kim [mailto:namhyung@gmail.com] On Behalf Of Namhyung Kim
>Sent: Thursday, September 10, 2015 11:27 AM
>To: Arnaldo Carvalho de Melo
>Cc: Ingo Molnar; Peter Zijlstra; Jiri Olsa; LKML; Wang Nan; 平松雅巳 / HIRAMATU,MASAMI
>Subject: [PATCH 1/3] perf probe: Free perf probe event in cleanup_perf_probe_events()
>
>The cleanup_perf_probe_events() frees all resources related to a perf
>probe event. However it only freed resources in trace probe events, not
>perf probe events. So call clear_perf_probe_event() too.

This looks good to me :)

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks!


>
>Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>Reported-by: Wang Nan <wangnan0@huawei.com>
>Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>---
> tools/perf/util/probe-event.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
>index 5964eccbe94d..3d7d60cc6f16 100644
>--- a/tools/perf/util/probe-event.c
>+++ b/tools/perf/util/probe-event.c
>@@ -2792,6 +2792,7 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs)
> clear_probe_trace_event(&pevs[i].tevs[j]);
> zfree(&pevs[i].tevs);
> pevs[i].ntevs = 0;
>+ clear_perf_probe_event(&pevs[i]);
> }
>
> exit_symbol_maps();
>--
>2.5.0

\
 
 \ /
  Last update: 2015-09-10 11:01    [W:0.094 / U:5.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site