lkml.org 
[lkml]   [2015]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
From
Date
On Tue, 2015-09-01 at 21:22 -0500, Zhao Qiang-B45475 wrote:
> On Wed, 2015-09-02 at 8:34AM +0800, Wood Scott-B07421 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, September 02, 2015 8:34 AM
> > To: Zhao Qiang-B45475
> > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> > lauraa@codeaurora.org; Xie Xiaobo-R63061; benh@kernel.crashing.org; Li
> > Yang-Leo-R58472; paulus@samba.org
> > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> > muram
> >
> > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> >
> > > -int cpm_muram_init(void)
> > > -{
> > > - struct device_node *np;
> > > - struct resource r;
> > > - u32 zero[OF_MAX_ADDR_CELLS] = {};
> > > - resource_size_t max = 0;
> > > - int i = 0;
> > > - int ret = 0;
> > > -
> > > - if (muram_pbase)
> > > - return 0;
> > > -
> > > - spin_lock_init(&cpm_muram_lock);
> > > - /* initialize the info header */
> > > - rh_init(&cpm_muram_info, 1,
> > > - sizeof(cpm_boot_muram_rh_block) /
> > > - sizeof(cpm_boot_muram_rh_block[0]),
> > > - cpm_boot_muram_rh_block);
> > > -
> > > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data");
> > > - if (!np) {
> > > - /* try legacy bindings */
> > > - np = of_find_node_by_name(NULL, "data-only");
> > > - if (!np) {
> > > - printk(KERN_ERR "Cannot find CPM muram data
> > node");
> > > - ret = -ENODEV;
> > > - goto out;
> > > - }
> > > - }
> > > -
> > > - muram_pbase = of_translate_address(np, zero);
> > > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > > - printk(KERN_ERR "Cannot translate zero through CPM muram
> > node");
> > > - ret = -ENODEV;
> > > - goto out;
> > > - }
> >
> > Did you pass -M -C to git format-patch?
>
>
> Yes!

Then maybe it's the qe/cpm rename churn, or similar, that prevented it from
being identified as a move?

-Scott



\
 
 \ /
  Last update: 2015-09-02 05:01    [W:0.119 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site