Messages in this thread | | | Subject | Re: [Open-FCoE] [PATCH] scsi: fcoe: Convert use of __constant_htons to htons | From | Vasu Dev <> | Date | Tue, 01 Sep 2015 15:43:24 -0700 |
| |
On Wed, 2015-08-19 at 11:18 +0530, Vaishali Thakkar wrote: > In little endian cases, the macro htons unfolds to __swab16 which > provides special case for constants. In big endian cases, > __constant_htons and htons expand directly to the same expression. > So, replace __constant_htons with htons with the goal of getting > rid of the definition of __constant_htons completely. > > The semantic patch that performs this transformation is as follows: > > @@expression x;@@ > > - __constant_htons(x) > + htons(x) > > Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> > --- > drivers/scsi/fcoe/fcoe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c > index ec193a8..d3eb80c 100644 > --- a/drivers/scsi/fcoe/fcoe.c > +++ b/drivers/scsi/fcoe/fcoe.c > @@ -364,7 +364,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe, > * on the ethertype for the given device > */ > fcoe->fcoe_packet_type.func = fcoe_rcv; > - fcoe->fcoe_packet_type.type = __constant_htons(ETH_P_FCOE); > + fcoe->fcoe_packet_type.type = htons(ETH_P_FCOE); > fcoe->fcoe_packet_type.dev = netdev; > dev_add_pack(&fcoe->fcoe_packet_type); >
Acked-by: Vasu Dev <vasu.dev@intel.com>
| |