lkml.org 
[lkml]   [2015]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] arm64: cpufeature.h: resolve hidden header dependencies
On Tue, Sep 01, 2015 at 03:41:11PM +0100, Yury Norov wrote:
> Functions implemented in cpufeature.h depend on some headers, but
> cpufeature.h does not include them. This may cause build failure if
> cpufeature.h user does not include that headers by itself. (Like it
> happens in next patch of this series.)
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> ---
> arch/arm64/include/asm/cpufeature.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h
> index c104421..20cdc26 100644
> --- a/arch/arm64/include/asm/cpufeature.h
> +++ b/arch/arm64/include/asm/cpufeature.h
> @@ -30,6 +30,11 @@
>
> #ifndef __ASSEMBLY__
>
> +#include <linux/bitmap.h>

We're also missing <linux/compiler.h> for the __attribute_const__ on
cpuid_feature_extract_field.

> +#include <linux/log2.h>

The cpu_feature macro using ilog2 is prior to the __ASSEMBLY__ guard.
Given it cannot be used by assembly, I think it should also be pulled
under the guard, or removed as it doesn't appear to be used anyway
(which would remove the need for this include).

Otherwise this looks good to me.

Thanks,
Mark.

> +#include <linux/printk.h>
> +#include <linux/types.h>
> +
> struct arm64_cpu_capabilities {
> const char *desc;
> u16 capability;
> --
> 2.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>


\
 
 \ /
  Last update: 2015-09-01 18:21    [W:0.081 / U:2.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site