Messages in this thread | | | Subject | Re: [PATCH 1/2] Input: atmel_mxt_ts - Implement support for T100 touch object | From | Javier Martinez Canillas <> | Date | Thu, 6 Aug 2015 13:19:12 +0200 |
| |
Hello,
On 08/06/2015 01:11 PM, Sjoerd Simons wrote: > + Corrected Javiers e-mail address. > On Thu, 2015-08-06 at 12:51 +0200, Dirk Behme wrote: >> On 17.03.2015 15:00, Javier Martinez Canillas wrote: >>> >> Having this patch in mainline as commit >> b23157dc74272ac8ebffd1a566e3e822dbc3e65f [1] breaks our Atmel touch. >> >> It seems that above >> >> + set_bit(EV_ABS, input_dev->evbit); >> >> is missing in the version which went into mainline? Re-adding it >> makes >> it work for us, again. >> >> Opinions? > > In mainline the EV_ABS bit automatically gets set as soon as > input_set_abs_params get called. > > If you're using this patch on an older kernel you should backport > 2c9a9cfec04f2c6ed7b4e607cd53ca903b2c4642 as well. >
That's correct. The reason why the original patch had that it's because it was forward ported from an older kernel and I missed that detail when doing the rebase.
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |