Messages in this thread | | | Date | Mon, 31 Aug 2015 12:57:08 -0800 | From | Kent Overstreet <> | Subject | Re: [GIT PULL] bcache revert |
| |
On Mon, Aug 31, 2015 at 02:47:45PM -0600, Jens Axboe wrote: > On 08/31/2015 02:42 PM, Kent Overstreet wrote: > >On Mon, Aug 31, 2015 at 02:25:25PM -0600, Jens Axboe wrote: > >>Kent, can we cut down on the victim playing? I said it should have been > >>posted, did I not? And usually patches like that ARE always posted, but this > >>beat the series of patches that it was a pre-patch for. Hence it just didn't > >>get posted, and that was a mistake, after a private discussion where it > >>ended up being cherry-picked for inclusion. Even for a trivial patch like > >>this. But it's not the end of the world, it's not like I rewrote your > >>architecture or grand caching design. > > > >You're backpedalling and trying not to admit it. Look, would you do it again or > >not? Because yes of course I'm going to call you out on it if you think this is > >an acceptable thing to do, which is certainly what you started off saying. > > Kent, this is starting to get into playground territory. Should it have been > posted/cc'ed to you? Yes. Do I think it's a big deal that it wasn't, given > the nature of the patch? No. Is/was the patch the right thing to do? Yes.
If you maintain that this is how you want to do things - I'm out, you can take over as bcache maintainer.
| |