Messages in this thread | | | Date | Mon, 31 Aug 2015 11:23:04 -0400 | From | "J. Bruce Fields" <> | Subject | Re: [RFC v6 10/40] richacl: Permission check algorithm |
| |
On Sat, Aug 29, 2015 at 12:06:22AM +0200, Andreas Grünbacher wrote: > 2015-08-28 23:49 GMT+02:00 J. Bruce Fields <bfields@fieldses.org>: > > On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote: > >> + /* > >> + * We don't care which class the process is in when the acl is > >> + * not masked. > >> + */ > >> + in_owner_or_group_class = 1; > > > > So why bother setting it at all, then? Oh, I see, it lets you break out > > of the loop below earlier. OK. > > Comment changed to: > > /* > * When the acl is not masked, there is no need to determine if > * the process is in the group class and we can earlier break > * out of the loop below. > */
makes sense, just replace "earlier break out" by "break out earlier".
> > > Patch makes sense to me, ACK. > > Thanks, > Andreas
| |