lkml.org 
[lkml]   [2015]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v6 10/40] richacl: Permission check algorithm
On Sat, Aug 29, 2015 at 12:06:22AM +0200, Andreas Grünbacher wrote:
> 2015-08-28 23:49 GMT+02:00 J. Bruce Fields <bfields@fieldses.org>:
> > On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote:
> >> + /*
> >> + * We don't care which class the process is in when the acl is
> >> + * not masked.
> >> + */
> >> + in_owner_or_group_class = 1;
> >
> > So why bother setting it at all, then? Oh, I see, it lets you break out
> > of the loop below earlier. OK.
>
> Comment changed to:
>
> /*
> * When the acl is not masked, there is no need to determine if
> * the process is in the group class and we can earlier break
> * out of the loop below.
> */

makes sense, just replace "earlier break out" by "break out earlier".

>
> > Patch makes sense to me, ACK.
>
> Thanks,
> Andreas


\
 
 \ /
  Last update: 2015-08-31 17:41    [W:1.486 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site