lkml.org 
[lkml]   [2015]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] selftests/zram: Adding zram tests
From
On 31 August 2015 at 09:37, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Tue, 2015-08-18 at 12:31 +0530, naresh.kamboju@linaro.org wrote:
>> From: Naresh Kamboju <naresh.kamboju@linaro.org>
>>
>> diff --git a/tools/testing/selftests/zram/Makefile b/tools/testing/selftests/zram/Makefile
>> new file mode 100644
>> index 0000000..ec45513
>> --- /dev/null
>> +++ b/tools/testing/selftests/zram/Makefile
>> @@ -0,0 +1,12 @@
>> +all:
>> +
>> +TEST_PROGS := zram.sh
>> +TEST_FILES := zram01.sh zram02.sh zram_lib.sh
>> +
>> +include ../lib.mk
>> +
>> +run_tests:
>> + @/bin/bash ./zram.sh
>> +
>

Michael,

> This is wrong, it gives me:
>
> $ make TARGETS=zram install
> ...
> Makefile:9: warning: overriding recipe for target 'run_tests'
> ../lib.mk:12: warning: ignoring old recipe for target 'run_tests'
>
>
> If you want to define run_tests you need to do:
>
> override define RUN_TESTS
> ./zram.sh
> endef
>
>
> BUT, I don't see any reason why you need to override run_tests. The default
> rule will just run TEST_PROGS, which is zram.sh so that should work fine?

Fixed according to your comments.
selftests/zram: Makefile fix - Patch sent for review.

Cheers
Naresh



>
> cheers
>
>


\
 
 \ /
  Last update: 2015-08-31 14:41    [W:0.069 / U:1.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site