Messages in this thread | | | Date | Sun, 30 Aug 2015 20:06:42 -0400 | From | "Frank Ch. Eigler" <> | Subject | timing of module MODULE_STATE_COMING notifier |
| |
Hi, Rusty -
We just [1] came across your patch [2] from last year (merged into 3.17), wherein the RO/NX mapping settings for module sections were moved to an earlier point in the module-loading sequence.
That patch also moved the MODULE_STATE_COMING notifier call to complete_formation(), which is relatively early to its former do_init_module() call site. It now precedes the parse_args(), mod_sysfs_setup(), and trace_module_load() steps.
Was the latter part of the change intended & necessary? It is negatively impacting systemtap, which was relying on MODULE_STATE_COMING being called from a fairly complete module state - just before the actual initializer function call.
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=18889
[2] commit 4982223e51e8ea9d09bb33c8323b5ec1877b2b51 Author: Rusty Russell <rusty@rustcorp.com.au> Date: Wed May 14 10:54:19 2014 +0930
- FChE
| |