lkml.org 
[lkml]   [2015]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] nfit: Fix undefined mmio_flush_range on x86_32
From
On Fri, Aug 28, 2015 at 6:18 PM, Toshi Kani <toshi.kani@hp.com> wrote:
> The following compile error was observed on x86_32 since nfit.c
> relies on <asm/pmem.h> to include <asm/cacheflush.h>, which only
> works when CONFIG_ARCH_HAS_PMEM_API is set on x86_64.
>
> drivers/acpi/nfit.c:1085:5: error: implicit declaration of
> function 'mmio_flush_range' [-Werror=implicit-function-declaration]
>
> Change nfit.c to include <asm/cacheflush.h> directly for now.
>
> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
> Apply on top of libnvdimm-for-next of the nvdimm tree.
> This is a temporary fix and please feel free to replace it with
> a better solution.

This looks correct to me, I'm going to fold it in to where the breakage occurs.

Thanks Toshi!


\
 
 \ /
  Last update: 2015-08-29 06:01    [W:2.054 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site