Messages in this thread | | | Subject | Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code | From | Toshi Kani <> | Date | Fri, 28 Aug 2015 15:48:26 -0600 |
| |
On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote: > On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani <toshi.kani@hp.com> wrote: > > On Wed, 2015-08-26 at 21:34 +0000, Williams, Dan J wrote: > [..] > > > -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB > > > > Should it be better to do: > > > > #else /* !CONFIG_ARCH_HAS_PMEM_API */ > > #define ARCH_MEMREMAP_PMEM MEMREMAP_WT > > > > so that you can remove all '#ifdef ARCH_MEMREMAP_PMEM' stuff? > > Yeah, that seems like a nice incremental cleanup for memremap_pmem() > to just unconditionally use ARCH_MEMREMAP_PMEM, feel free to send it > along.
OK. Will do.
Thanks, -Toshi
| |