lkml.org 
[lkml]   [2015]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [v4] surface pro 3: Add support driver for Surface Pro 3 buttons
On Wed, Aug 26, 2015 at 05:04:01AM -0700, Joe Perches wrote:
> On Wed, 2015-08-26 at 00:22 -0700, Darren Hart wrote:
> > On Tue, Aug 18, 2015 at 11:30:25PM +0800, Chen Yu wrote:
> > > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design
> > > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can
> > > not detect these buttons on it. According to bios implementation,
> > > Surface Pro 3 encapsulates these buttons in a device named "VGBI",
> > > with _HID "MSHW0028". When any of the buttons is pressed, a specify
> > > ACPI notification code for this button will be delivered to "VGBI". For
> > > example, if power button is pressed down, ACPI notification code of 0xc6
> > > will be sent by Notify(VGBI, 0xc6).
> []
> > Joe, you provided a lot of review, are you happy with this version?
>
> It looks fine.
>
> Thanks for picking the other little nits too Darren.

This is not queued for next.

--
Darren Hart
Intel Open Source Technology Center


\
 
 \ /
  Last update: 2015-08-28 20:01    [W:0.833 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site