Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH V4 2/2] PM / OPP: Fix static checker warning (broken 64bit big endian systems) | Date | Fri, 28 Aug 2015 16:14:33 +0200 |
| |
On Monday, August 17, 2015 07:20:20 PM Viresh Kumar wrote: > Dan Carpenter reported (generated with static checker): > > drivers/base/power/opp.c:949 _opp_add_static_v2() > warn: passing casted pointer '&new_opp->clock_latency_ns' to > 'of_property_read_u32()' 64 vs 32. > > This code will break on 64 bit, big endian machines. > > Fix this by reading the value in a u32 type variable first and then > assigning it to the unsigned long variable. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Suggested-by: Stephen Boyd <sboyd@codeaurora.org> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
I've applied this and the [1/2], thanks!
Rafael
| |