Messages in this thread | | | Date | Thu, 27 Aug 2015 11:13:23 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf script: Add --[no-]-demangle/--[no-]-demangle-kernel |
| |
Em Wed, Aug 26, 2015 at 12:18:15PM -0700, Yannick Brosseau escreveu: > From: Mark Drayton <mbd@fb.com> > > Summary: Sometimes when post-processing output from `perf script` one > does not want to demangle C++ symbol names. Add an option to allow this. > Also add --[no-]demangle-kernel to be consistent with top/report/probe. > > Signed-off-by: Mark Drayton <mbd@fb.com> > Signed-off-by: Yannick Brosseau <scientist@fb.com>
Thanks, applied after fixing up it wrt other changes in builtin-script.c, next time, for new features like this, make sure it applies to my perf/core branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
- Arnaldo
> --- > tools/perf/Documentation/perf-script.txt | 7 +++++++ > tools/perf/builtin-script.c | 4 ++++ > 2 files changed, 11 insertions(+) > > diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt > index c82df57..347c73a 100644 > --- a/tools/perf/Documentation/perf-script.txt > +++ b/tools/perf/Documentation/perf-script.txt > @@ -222,6 +222,13 @@ OPTIONS > --show-mmap-events > Display mmap related events (e.g. MMAP, MMAP2). > > +--demangle:: > + Demangle symbol names to human readable form. It's enabled by default, > + disable with --no-demangle. > + > +--demangle-kernel:: > + Demangle kernel symbol names to human readable form (for C++ kernels). > + > --header > Show perf.data header. > > diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c > index 24809787..f3b3ba0 100644 > --- a/tools/perf/builtin-script.c > +++ b/tools/perf/builtin-script.c > @@ -1622,6 +1622,10 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused) > OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts", > "Instruction Tracing options", > itrace_parse_synth_opts), > + OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle, > + "Enable symbol demangling"), > + OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel, > + "Enable kernel symbol demangling"), > OPT_END() > }; > const char * const script_subcommands[] = { "record", "report", NULL }; > -- > 2.1.4
| |