lkml.org 
[lkml]   [2015]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] ARM: STi: DT: STiH407: Add FDMA driver and xbar driver dt nodes.
On Wed, 08 Jul 2015, Peter Griffin wrote:

> These nodes are required to get the fdma and xbar driver working
> on STiH407 based silicon.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> arch/arm/boot/dts/stih407-family.dtsi | 59 +++++++++++++++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> index 838b812..b6d9e20 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -565,5 +565,64 @@
> <&phy_port2 PHY_TYPE_USB3>;
> };
> };
> +
> + xbar0: fdma-xbar-mpe@0 {

The unit address should match the one in the reg property.

> + compatible = "st,fdma-xbar-1.0";

Is that a version number in the compatible string?

> + reg = <0x8e80000 0x1000>;
> + dma-requests = <79>;
> + #st,fdma-xbar-cells = <1>;

Why can't FDMA use the generic DMA properties?

> + };
> +
> + fdma0: fdma-audio@0 {

Same comment as above.

> + compatible = "st,fdma_mpe31";

DT doesn't usually like underscores.

> + reg = <0x8e20000 0x20000>;
> + interrupts = <GIC_SPI 5 IRQ_TYPE_NONE>;
> + dma-channels = <16>;
> + #dma-cells = <3>;
> + st,fw-name = "fdma_STiH407_0.elf";

I've bought this up before somewhere (although there doesn't appear to
be a Firmware Maintainer), surely we should define a generic binding
for passing firmware names? Many vendors are going to require it.

> + clocks = <&clk_s_c0_flexgen CLK_FDMA>,
> + <&clk_s_c0_flexgen CLK_EXT2F_A9>,
> + <&clk_s_c0_flexgen CLK_EXT2F_A9>,
> + <&clk_s_c0_flexgen CLK_EXT2F_A9>;
> + clock-names = "fdma_slim",
> + "fdma_hi",
> + "fdma_low",
> + "fdma_ic";
> + };
> +
> + fdma1: fdma-app@1 {

As above.

> + compatible = "st,fdma_mpe31";

As above.

> + reg = <0x8e40000 0x20000>;
> + interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>;
> + dma-channels = <16>;
> + #dma-cells = <3>;
> + st,fdma-xbar = <&xbar0 0>;
> + st,fw-name = "fdma_STiH407_1.elf";
> + clocks = <&clk_s_c0_flexgen CLK_FDMA>,
> + <&clk_s_c0_flexgen CLK_TX_ICN_DMU>,
> + <&clk_s_c0_flexgen CLK_TX_ICN_DMU>,
> + <&clk_s_c0_flexgen CLK_EXT2F_A9>;
> + clock-names = "fdma_slim",
> + "fdma_hi",
> + "fdma_low",
> + "fdma_ic";
> + };
> +
> + fdma2: fdma-free_running@2 {
> + compatible = "st,fdma_mpe31";
> + reg = <0x8e60000 0x20000>;
> + interrupts = <GIC_SPI 9 IRQ_TYPE_NONE>;
> + dma-channels = <16>;
> + #dma-cells = <3>;
> + st,fw-name = "fdma_STiH407_2.elf";
> + clocks = <&clk_s_c0_flexgen CLK_FDMA>,
> + <&clk_s_c0_flexgen CLK_EXT2F_A9>,
> + <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>,
> + <&clk_s_c0_flexgen CLK_EXT2F_A9>;
> + clock-names = "fdma_slim",
> + "fdma_hi",
> + "fdma_low",
> + "fdma_ic";
> + };
> };
> };

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-08-26 10:01    [W:0.157 / U:2.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site