Messages in this thread | | | Date | Tue, 25 Aug 2015 19:56:31 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v4 4/5] spi: bcm2835: new driver implementing auxiliar spi1/spi2 on the bcm2835 soc |
| |
On 08/24/2015 02:40 AM, kernel@martin.sperl.org wrote: > From: Martin Sperl <kernel@martin.sperl.org>
Patch description?
> arch/arm/configs/bcm2835_defconfig | 1 + > drivers/spi/Kconfig | 12 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-bcm2835aux.c | 506 ++++++++++++++++++++++++++++++++++++
A change to the defconfig would be applied by the RPi maintainers, and a change to drivers/spi by the SPI maintainers. Those need to be in different patches.
> diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c
> +static int bcm2835aux_spi_probe(struct platform_device *pdev)
> + clk_prepare_enable(bs->clk);
Error checking?
> + /* enable HW block */ > + bcm2835aux_enable(&pdev->dev, ENABLE_PROPERTY);
The return value needs to be error-checked, so that deferred probe can work, and so other kinds of errors can be detected. Wasn't this correct in a previous patch version?
Note that I didn't review any code besides probe(), remove() and the driver boiler-plate that refers to those functions.
| |