Messages in this thread | | | Date | Tue, 25 Aug 2015 20:24:14 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCHv3 1/5] mm: drop page->slab_page |
| |
On Mon, Aug 24, 2015 at 05:02:16PM +0200, Vlastimil Babka wrote: > On 08/19/2015 11:21 AM, Kirill A. Shutemov wrote: > >Since 8456a648cf44 ("slab: use struct page for slab management") nobody > >uses slab_page field in struct page. > > > >Let's drop it. > > Ah, how about dropping this comment in mm/slab.c:slab_destroy() as well? > > /* > * RCU free overloads the RCU head over the LRU. > * slab_page has been overloeaded over the LRU, > * however it is not used from now on so that > * we can use it safely. > */
Actually, whole block can be replaced by
call_rcu(&page->rcu_head, kmem_rcu_free);
Thanks.
-- Kirill A. Shutemov
| |