Messages in this thread | | | Date | Tue, 25 Aug 2015 09:46:50 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC |
| |
On Wed, 26 Aug 2015, Qipeng Zha wrote:
> IRQ control registers of Intel Broxton Whisky Cove PMIC are > separated in two parts, so add secondary IRQ chip. > And the new member of device will be used in PMC IPC regmap APIs. > > Signed-off-by: Qipeng Zha <qipeng.zha@intel.com> > --- > include/linux/mfd/intel_soc_pmic.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mfd/intel_soc_pmic.h b/include/linux/mfd/intel_soc_pmic.h > index abcbfcf..a730f14 100644 > --- a/include/linux/mfd/intel_soc_pmic.h > +++ b/include/linux/mfd/intel_soc_pmic.h > @@ -21,10 +21,15 @@ > > #include <linux/regmap.h> > > +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \ > + [_irq] = { .reg_offset = (_off), .mask = (_mask) } > +
No, that's not what I asked.
Either this macro is going to be useful to *everyone*, or it's probably not useful to *anyone*. If it's going to exist, it should exist in the core header file, not Intel's own.
> struct intel_soc_pmic { > int irq; > struct regmap *regmap; > struct regmap_irq_chip_data *irq_chip_data; > + struct regmap_irq_chip_data *irq_chip_data_level2; > + struct device *dev; > }; > > #endif /* __INTEL_SOC_PMIC_H__ */
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |