Messages in this thread | | | Date | Mon, 24 Aug 2015 12:36:07 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCHv3 0/5] Fix compound_head() race |
| |
On Sat, Aug 22, 2015 at 01:13:19PM -0700, Hugh Dickins wrote: > Yes, I did think the compound destructor enum stuff over-engineered, > and would have preferred just direct calls to free_compound_page() > or free_huge_page() myself. But when I tried to make a patch on > top to do that, even when I left PageHuge out-of-line (which had > certainly not been my intention), it still generated more kernel > text than Kirill's enum version (maybe his "- 1" in compound_head > works better in some places than masking out 3, I didn't study); > so let's forget about that.
I had my agenda on ->compound_dtor: my refcounting patchset introduces one more compound destructor. I wanted to avoid hardcoding them here.
-- Kirill A. Shutemov
| |