Messages in this thread | | | Date | Sun, 23 Aug 2015 20:32:21 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding documentation |
| |
Hi Justin,
On 08/20/2015 10:41 AM, Justin Chen wrote: > Add device tree binding docmentation for the watchdog hardware block > on bcm7038 and newer SoCs. > > Signed-off-by: Justin Chen <justinpopo6@gmail.com> > --- > .../devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > new file mode 100644 > index 0000000..adb8260 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.txt > @@ -0,0 +1,19 @@ > +BCM7038 Watchdog timer > + > +Required properties: > + > +- compatible : should be "brcm,bcm7038-wdt" > +- reg : Specifies base physical address and size of the registers. > + > +Optional properties: > + > +- clocks: the clock running the watchdog > +- clock-frequency: the rate of the clock
Is 'clock-frequency' really needed (and useful), or would it make more sense to expect the user to configure a fixed clock if nothing else is available ? How do other drivers handle this ?
Thanks, Guenter
> + > +Example: > + > +watchdog { > + compatible = "brcm,bcm7038-wdt"; > + clocks = <&upg_fixed>; > + reg = <0xf040a7e8 0x16>; > +}; >
| |