Messages in this thread | | | Date | Fri, 21 Aug 2015 22:42:01 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH/RFC v6 05/36] leds: Improve setting brightness in a non sleeping way |
| |
> This work queue from led-class.c is used for setting brightness, when > blink timer is on. Blinking is the functionality from the LED core, > so the work queue should also belong to the core. It should be moved > there along with led_timer_function, for consistency reasons. In view > of the above, using it for setting brightness by blocking drivers > would be correct from the architectural point of view.
So lets assume we are not doing all the changes in a single patch set. Its too complex. You say the work queue should be in the core. Lets put a work queue in the core to handle the blocking op, and strip it out of the drivers. That allows you to get a lot of driver patches merged.
You can then work on moving led_timer_function into the core, etc, with a much smaller patch set, and hopefully in a number of small steps which are easy to review.
Andrew
| |