Messages in this thread | | | Date | Fri, 21 Aug 2015 11:24:04 -0700 | Subject | Re: [PATCH v4 43/52] OF/PCI: Add IORESOURCE_MEM_64 for 64-bit resource | From | Yinghai Lu <> |
| |
On Fri, Aug 21, 2015 at 11:18 AM, Rob Herring <robherring2@gmail.com> wrote: > On Fri, Aug 21, 2015 at 1:20 AM, Yinghai Lu <yinghai@kernel.org> wrote: >> For device resource PREF bit setting under bridge 64-bit pref resource, >> we need to make sure only set PREF for 64bit resource, so set >> IORESOUCE_MEM_64 for 64bit resource during OF device resource flags >> parsing. >> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=96261 >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=96241 >> Signed-off-by: Yinghai Lu <yinghai@kernel.org> >> Cc: Grant Likely <grant.likely@linaro.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: devicetree@vger.kernel.org > > My comment from v1[1] is not addressed still. > > > [1] https://lkml.org/lkml/2015/7/10/736
| As the BZ says, we have several identical functions. Can we fix the | drivers/of/address.c version and remove the Sparc versions. The only | diff is the generic version converts from be32. I think that should be | a nop for Sparc.
That would be better to let guys with Sparc or other OF arch to do the unification.
Yinghai
| |